Background: Epidemiological studies have reported that dietary mineral intake plays an important role on lung cancer risk, but the association of sodium, potassium intake is still unclear. Methods: We determined the association between dietary sodium, potassium intake and lung cancer risk based on the Prostate, Lung, Colorectal and Ovarian (PLCO) cancer screening trial and the Women's Health Initiative (WHI). Totally 165,409 participants who completed the baseline questionnaire (BQ) and diet history questionnaire (DHQ) were included into the analytical dataset, including 92,984 (44,959 men and 48,025 women) from the PLCO trial and 72,425 (women only) from the WHI cohort. Multivariable Cox proportional hazards regression was used to calculate hazard ratios (HRs) and 95% confidence intervals (CIs) of incident lung cancer associated with dietary potassium and sodium intake. The dose-response relationship was also described using the spline smoothed curve after adjusting covariates. Results: After the median follow-up of 8.55 and 18.56 years, 1,278 and 1,631 new cases of lung cancer were identified in the PLCO trial and WHI cohort, respectively. Intake of sodium was significantly associated with the incidence of lung cancer in the PLCO trial after multivariate adjustment for men (HR: 1.19, 95% CI: 1.05-1.35; P for linear trend =0.044). There was a suggestion that lung cancer risk had a quadratic curve correlation with the increase of potassium intake for women (third vs. lowest quintile: HR: 0.72, 95% CI: 0.54-0.96; P for quadratic trend =0.042). The similar results showing an inverse association between potassium intake and lung cancer risk were also observed in the WHI cohort for women (highest vs. lowest quintile: HR: 0.82, 95% CI: 0.70-0.97; P for linear trend =0.009). Conclusions: Appropriate intake of potassium has a protective effect against lung cancer, while high consumption of sodium is associated with an increased risk of lung cancer.